Skip to content

Backup stream#1

Open
Aditya8840 wants to merge 4 commits intomainfrom
backup-stream
Open

Backup stream#1
Aditya8840 wants to merge 4 commits intomainfrom
backup-stream

Conversation

@Aditya8840
Copy link
Copy Markdown
Owner

Fixes:

Screenshots and screen captures:

Self-review checklist
  • Self-reviewed the changes for clarity and maintainability
    (variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

  • Explains differences from previous plans (e.g., issue description).
  • Highlights technical choices and bugs encountered.
  • Calls out remaining decisions and concerns.
  • Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

  • Each commit is a coherent idea.
  • Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

  • Visual appearance of the changes.
  • Responsiveness and internationalization.
  • Strings and tooltips.
  • End-to-end functionality of buttons, interactions and flows.
  • Corner cases, error conditions, and easily imagined bugs.

This commit extracts the common logic for bulk-checking basic stream
access into a separate function, reducing redundancy when introducing
can_unsubscribe_group.
This commit makes the function reusable, helping reduce code
duplication.
Previously, when a user attempted to unsubscribe others from a
stream they didn't have access to, the system returned an
"Insufficient permission" error. This commit updates the behavior
to raise an "Invalid channel ID" error instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant